-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[next] tree: promote changes from next-devel at ad8729d2564e9f1e18cd2da2b6f069fc65893f5f #2612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreosbot-releng
force-pushed
the
next-promotion
branch
from
September 16, 2023 13:28
6a57be5
to
9889bc7
Compare
dustymabe
reviewed
Sep 16, 2023
@@ -2,6 +2,6 @@ variables: | |||
stream: next | |||
prod: true | |||
|
|||
releasever: 38 | |||
releasever: 39 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is expected since we are moving to F39.
We switched to IMDSV2 by default in COSA so let's update our call here. coreos/coreos-assembler#3607
Now that we have moved the next stream over to F39 we'll need these denials to apply there too.
dustymabe
force-pushed
the
next-promotion
branch
from
September 16, 2023 20:33
ad20a4d
to
2c1a8f6
Compare
Let me try to fix that. |
This will prevent a "downgrade" in the `next` stream when upgrading from the last `next` stream release based on Fedora 38. coreos#2612 (comment)
jlebon
approved these changes
Sep 17, 2023
dustymabe
added a commit
that referenced
this pull request
Sep 17, 2023
This will prevent a "downgrade" in the `next` stream when upgrading from the last `next` stream release based on Fedora 38. #2612 (comment)
marmijo
added a commit
to marmijo/fedora-coreos-config
that referenced
this pull request
Sep 25, 2023
Now that the `next` stream has had a build based on Fedora 39, we can remove this pin. The next build of `next` shouldnt see the "downgrade" message as seen in: coreos#2612 (comment) This reverts commit 7ccc4f5.
marmijo
added a commit
to marmijo/fedora-coreos-config
that referenced
this pull request
Sep 25, 2023
Now that there is a newer NVR version of grub2 (grub2-2.06-100.fc39) in the bodhi stable state than what is in Fedora 38 we can unpin the grub2 override that was necessary to prevent a downgrade in: coreos#2612 (comment) This reverts commit 7ccc4f5.
dustymabe
pushed a commit
that referenced
this pull request
Sep 25, 2023
Now that there is a newer NVR version of grub2 (grub2-2.06-100.fc39) in the bodhi stable state than what is in Fedora 38 we can unpin the grub2 override that was necessary to prevent a downgrade in: #2612 (comment) This reverts commit 7ccc4f5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggered by @dustymabe in coreos/fedora-coreos-streams#762.